linux-kernel - Re: [PATCH -mm 1/3] proc: randomize "struct pde

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jKv5EehXn7tNc9n=Zd_tT5AcNeQm5_rT81m6OAWXXpMYQ@mail.gmail.com>
Date:   Thu, 15 Feb 2018 16:53:29 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -mm 1/3] proc: randomize "struct pde_opener"

On Wed, Feb 14, 2018 at 12:19 AM, Alexey Dobriyan <adobriyan@...il.com> wrote:
> The more the merrier.

What made you choose this structure, BTW?

> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
> ---
>
>  fs/proc/internal.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/fs/proc/internal.h
> +++ b/fs/proc/internal.h
> @@ -177,7 +177,7 @@ struct pde_opener {
>         struct list_head lh;
>         bool closing;
>         struct completion *c;
> -};
> +} __randomize_layout;
>  extern const struct inode_operations proc_link_inode_operations;
>
>  extern const struct inode_operations proc_pid_link_inode_operations;

-Kees

-- 
Kees Cook
Pixel Security