linux-kernel - Re: [PATCH v3 1/2] ASoC: codecs: Add support for AK4458 DAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180216115436.GF5886@sirena.org.uk>
Date:   Fri, 16 Feb 2018 11:54:36 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Cosmin-Gabriel Samoila <cosmin.samoila@....com>
Cc:     alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        robh@...nel.org, mihai.serban@...il.com, linux-imx@....com,
        shegjiu.wang@....com, daniel.baluta@....com,
        linux-kernel@...r.kernel.org,
        Junichi Wakasugi <wakasugi.jb@...asahi-kasei.co.jp>,
        Mihai Serban <mihai.serban@....com>,
        Shengjiu Wang <shengjiu.wang@....com>
Subject: Re: [PATCH v3 1/2] ASoC: codecs: Add support for AK4458 DAC driver

On Wed, Feb 14, 2018 at 03:21:06PM +0200, Cosmin-Gabriel Samoila wrote:

> --- /dev/null
> +++ b/sound/soc/codecs/ak4458.c
> @@ -0,0 +1,659 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Audio driver for AK4458 DAC
> + *

Please don't mix C and C++ comments line this, just make the entire
block a C++ comment.  Since this looks otherwise good I'll apply this,
please send a followup patch fixing the above.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)