linux-kernel - Re: [PATCH v4 1/2] ASoC: codecs: Add support for AK5558 ADC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1518784101.9517.21.camel@nxp.com>
Date:   Fri, 16 Feb 2018 12:28:21 +0000
From:   Daniel Baluta <daniel.baluta@....com>
To:     "pombredanne@...b.com" <pombredanne@...b.com>,
        "broonie@...nel.org" <broonie@...nel.org>
CC:     dl-linux-imx <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Cosmin Samoila <cosmin.samoila@....com>,
        "daniel.baluta@...il.com" <daniel.baluta@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "wakasugi.jb@...asahi-kasei.co.jp" <wakasugi.jb@...asahi-kasei.co.jp>,
        "andy.shevchenko@...il.com" <andy.shevchenko@...il.com>,
        Fabio Estevam <fabio.estevam@....com>,
        "mihai.serban@...il.com" <mihai.serban@...il.com>,
        "robh@...nel.org" <robh@...nel.org>,
        "S.j. Wang" <shengjiu.wang@....com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "mihai.serban@....com" <mihai.serban@....com>
Subject: Re: [PATCH v4 1/2] ASoC: codecs: Add support for AK5558 ADC driver

On Vi, 2018-02-16 at 12:14 +0000, Mark Brown wrote:
> On Tue, Feb 13, 2018 at 04:29:33PM +0200, Daniel Baluta wrote:
> 
> > 
> > +++ b/sound/soc/codecs/ak5558.c
> > @@ -0,0 +1,417 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> Just make this a C++ commment, don't mix C and C++ - it looks neater.
> Otherwise this looks good so I'll apply, please send a followup patch
> for the above.

Hi Mark,

Will send a separate patch to fix this.

Anyhow, lets make sure that I got it right because looking into
sound/soc/codecs I can see a mixes of styles.

So, for ak5558.c the correct code should be:

// SPDX-License-Identifier: GPL-2.0
//
// Audio driver for AK5558 ADC
//
// Copyright (C) 2015 Asahi Kasei Microdevices Corporation
// Copyright 2018 NXP
//

Now, for the .h there is a total different story. As per Philippe's
link to documentation [1]

the .h file should start with:

C header:	/* SPDX-License-Identifier: <SPDX License Expression> */

So, is the header ak5558.h looking like this, all right?


/* SPDX-License-Identifier: GPL-2.0 */
/*
 * Audio driver header for AK5558
 *
 * Copyright (C) 2016 Asahi Kasei Microdevices Corporation
 * Copyright 2018 NXP
 */

Are you willing to take patches fixing the SPDX identifier for the rest of the codecs in sounc/soc/codecs?

I've got a bunch of students looking for cleanup patches in their application for Google Summer of Code :).

thanks,
Daniel.

[1]https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst#n67