linux-kernel - Re: [PATCH][next] HID: asus: make array 'buf' static const, shrinks object size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.1802161335000.13621@cbobk.fhfr.pm>
Date:   Fri, 16 Feb 2018 13:35:10 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Colin King <colin.king@...onical.com>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] HID: asus: make array 'buf' static const, shrinks
 object size

On Sat, 6 Jan 2018, Colin King wrote:

> From: Colin Ian King <colin.king@...onical.com>
> 
> Don't populate the const read-only array 'buf' on the stack but instead
> make it stati. Makes the object code smaller by 26 bytes:
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>   14378	   2384	     64	  16826	   41ba	linux/drivers/hid/hid-asus.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>   14296	   2440	     64	  16800	   41a0	linux/drivers/hid/hid-asus.o
> 
> (gcc version 7.2.0 x86_64)
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied to for-4.17/upstream.

-- 
Jiri Kosina
SUSE Labs