linux-kernel - Re: [PATCH] HID: uhid: use strlcpy() instead of strncpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.1802161337050.13621@cbobk.fhfr.pm>
Date:   Fri, 16 Feb 2018 13:37:15 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Xiongfeng Wang <wangxiongfeng2@...wei.com>
cc:     benjamin.tissoires@...hat.com, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: uhid: use strlcpy() instead of strncpy()

On Tue, 9 Jan 2018, Xiongfeng Wang wrote:

> From: Xiongfeng Wang <xiongfeng.wang@...aro.org>
> 
> gcc-8 reports
> 
> drivers/hid/uhid.c: In function 'uhid_dev_create2':
> ./include/linux/string.h:245:9: warning: '__builtin_strncpy' output may
> be truncated copying 127 bytes from a string of length 127
> [-Wstringop-truncation]
> 
> The compiler require that the input param 'len' of strncpy() should be
> greater than the length of the src string, so that '\0' is copied as
> well. We can just use strlcpy() to avoid this warning.

Applied to for-4.17/upstream.

-- 
Jiri Kosina
SUSE Labs