linux-kernel - Re: [PATCH 3/3] percpu: Remove inert tracepoint in _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180216125217.zhhn3j2ar55wchh2@treble>
Date:   Fri, 16 Feb 2018 06:52:17 -0600
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     Tejun Heo <tj@...nel.org>, x86@...nel.org,
        linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Jason Baron <jbaron@...mai.com>, Borislav Petkov <bp@...e.de>
Subject: Re: [PATCH 3/3] percpu: Remove inert tracepoint in __init code

On Fri, Feb 16, 2018 at 10:02:33AM +0100, Ingo Molnar wrote:
> 
> * Josh Poimboeuf <jpoimboe@...hat.com> wrote:
> 
> > On Thu, Feb 15, 2018 at 07:22:46AM -0800, Tejun Heo wrote:
> > > On Wed, Feb 14, 2018 at 10:40:43AM -0600, Josh Poimboeuf wrote:
> > > > The jump_label code doesn't patch init code, so this tracepoint can
> > > > never be enabled.  Remove it.
> > > > 
> > > > Cc: Tejun Heo <tj@...nel.org>
> > > > Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
> > > 
> > > Applied to percpu/for-4.17.
> > 
> > Actually, I think this patch should be dropped.  As Jason pointed out,
> > tracepoints *can* be enabled at boot time for __init code, so it's
> > possible for this tracepoint to be used.
> 
> Would it still be useful to have the warning for failed patching?

Yes, I'm working on a v2.

-- 
Josh