linux-kernel - Re: [PATCH] iio: apply coding-style into ms5611

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1518789437.9517.32.camel@nxp.com>
Date:   Fri, 16 Feb 2018 13:57:17 +0000
From:   Daniel Baluta <daniel.baluta@....com>
To:     "knaack.h@....de" <knaack.h@....de>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "rodrigosiqueiramelo@...il.com" <rodrigosiqueiramelo@...il.com>,
        "jic23@...nel.org" <jic23@...nel.org>,
        "pmeerw@...erw.net" <pmeerw@...erw.net>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] iio: apply coding-style into ms5611_probe function

Hi Rodrigo,

Mostly looking good. Few comments.

Please read:

https://chris.beams.io/posts/git-commit/

1) Capitalize the first letter of commit
2) Use prefix tags to indicate the driver that is changed. Here iio:pressure:ms5611.

If not sure what prefix tags to use please use git log file.c and see the tags used by previous commits.
If not clear from previous commits be creative! :)

3) A better verb describing the change would be Fix instead of Apply.

So, the commit subject should be:

iio:pressure:ms5611: Fix coding style in probe function

4) Please correct all the occurences of the same coding style error (not sure if here is the case).

Other than that it looks good to me. Please send v2.

Do not forget to add under the scissor line of the new patch a small changelog documenting what
has changed since v1.

On Vi, 2018-02-16 at 11:38 -0200, rodrigosiqueira wrote:
> This patch fixes the checkpatch.pl warning and error:
> 
> iio/pressure/ms5611.h:66: ERROR: code indent should use tabs where possible
> iio/pressure/ms5611.h:66: WARNING: please, no spaces at the start of a line
> iio/pressure/ms5611.h:66: ERROR: "foo* bar" should be "foo *bar"
> 
> Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@...il.com>
> ---
> 

^ this is the scissor line.

thanks,
Daniel.