linux-kernel - RE: [PATCH] rtc: tx4939: avoid unintended sign extension on a 24 bit shift

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d943a549d051472c98e3c163dc4245ac@AcuMS.aculab.com>
Date:   Fri, 16 Feb 2018 15:14:51 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Andy Shevchenko' <andy.shevchenko@...il.com>,
        Colin King <colin.king@...onical.com>
CC:     Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] rtc: tx4939: avoid unintended sign extension on a 24 bit
 shift

From: Andy Shevchenko
> Sent: 16 February 2018 14:23
...
> Wouldn't be better to use le32_to_cpu() or get_unaligned()?

Or shoot the members of the ANSI C committee who insisted on
promotion of unsigned char/short to int and sign preserving
promotion of int to unsigned long :-)

	David