linux-kernel - Re: [PATCH] i40evf: remove redundant array comparisons to 0 checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb8a38bd-73a0-5f44-5e89-d9ded5be1800@canonical.com>
Date:   Fri, 16 Feb 2018 16:53:21 +0000
From:   Colin Ian King <colin.king@...onical.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        intel-wired-lan@...ts.osuosl.org, netdev <netdev@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i40evf: remove redundant array comparisons to 0 checks

On 16/02/18 16:51, Andy Shevchenko wrote:
> On Thu, Feb 15, 2018 at 9:42 PM, Colin King <colin.king@...onical.com> wrote:
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> The checks to see if key->dst.s6_addr and key->src.s6_addr are null
>> pointers are redundant because these are constant size arrays and
>> so the checks always return true.  Fix this by removing the redundant
>> checks.
> 
>> +               for (i = 0; i < 4; i++)
> 
>> +                       filter->f.mask.tcp_spec.dst_ip[i] |=
>>                                                         cpu_to_be32(0xffffffff);
> 
> Can it be one line then?

I re-adjusted the text because checkpatch was complaining.

> 
>> +               memcpy(&filter->f.data.tcp_spec.dst_ip,
>> +                      &key->dst.s6_addr32,
> 
> Ditto.
> 
>> +                      sizeof(filter->f.data.tcp_spec.dst_ip));
>> +
>> +               for (i = 0; i < 4; i++)
> 
>> +                       filter->f.mask.tcp_spec.src_ip[i] |=
>>                                                         cpu_to_be32(0xffffffff);
> 
> Ditto.
> 
>> +               memcpy(&filter->f.data.tcp_spec.src_ip,
>> +                      &key->src.s6_addr32,
> 
> Ditto.
> 
>> +                      sizeof(filter->f.data.tcp_spec.src_ip));
>