linux-kernel - Re: [PATCH v4 4/5] x86/apic: Rename variable/function related to x86_io_apic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201802161207.A77kVJh1%fengguang.wu@intel.com>
Date:   Fri, 16 Feb 2018 13:15:17 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Baoquan He <bhe@...hat.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        ebiederm@...ssion.com, mingo@...nel.org, tglx@...utronix.de,
        x86@...nel.org, douly.fnst@...fujitsu.com, joro@...tes.org,
        uobergfe@...hat.com, prarit@...hat.com, Baoquan He <bhe@...hat.com>
Subject: Re: [PATCH v4 4/5] x86/apic: Rename variable/function related to
 x86_io_apic_ops

Hi Baoquan,

I love your patch! Yet something to improve:

[auto build test ERROR on tip/auto-latest]
[also build test ERROR on v4.16-rc1 next-20180215]
[cannot apply to tip/x86/core]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Baoquan-He/x86-apic-Fix-restoring-boot-irq-mode-in-reboot-and-kexec-kdump/20180216-121305
config: i386-randconfig-x070-201806 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   arch/x86/kernel/reboot.c: In function 'native_machine_shutdown':
>> arch/x86/kernel/reboot.c:683:2: error: implicit declaration of function 'restore_boot_irq_mode'; did you mean 'native_restore_boot_irq_mode'? [-Werror=implicit-function-declaration]
     restore_boot_irq_mode();
     ^~~~~~~~~~~~~~~~~~~~~
     native_restore_boot_irq_mode
   cc1: some warnings being treated as errors
--
   arch/x86/kernel/crash.c: In function 'native_machine_crash_shutdown':
>> arch/x86/kernel/crash.c:205:2: error: implicit declaration of function 'restore_boot_irq_mode'; did you mean 'native_restore_boot_irq_mode'? [-Werror=implicit-function-declaration]
     restore_boot_irq_mode();
     ^~~~~~~~~~~~~~~~~~~~~
     native_restore_boot_irq_mode
   cc1: some warnings being treated as errors

vim +683 arch/x86/kernel/reboot.c

^1da177e arch/i386/kernel/reboot.c Linus Torvalds 2005-04-16  681  
^1da177e arch/i386/kernel/reboot.c Linus Torvalds 2005-04-16  682  	lapic_shutdown();
4bfde7d3 arch/x86/kernel/reboot.c  Baoquan He     2018-02-13 @683  	restore_boot_irq_mode();
^1da177e arch/i386/kernel/reboot.c Linus Torvalds 2005-04-16  684  

:::::: The code at line 683 was first introduced by commit
:::::: 4bfde7d3821a914fb062d96979559723e5871c3d x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump

:::::: TO: Baoquan He <bhe@...hat.com>
:::::: CC: 0day robot <fengguang.wu@...el.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (25639 bytes)