linux-kernel - Re: [PATCH] Staging: ks7010: fix unnecessary parentheses in ks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180217115342.GB9433@kroah.com>
Date:   Sat, 17 Feb 2018 12:53:42 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Yash Omer <yashomer0007@...il.com>
Cc:     devel@...verdev.osuosl.org, florian.c.schilhabel@...glemail.com,
        driverdev-devel@...uxdriverproject.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: ks7010: fix unnecessary parentheses in
 ks_hostif.c

On Sat, Feb 17, 2018 at 03:26:45PM +0530, Yash Omer wrote:
> This patch fixes up unncessary parentheses warning found by checkpatch.pl script
> 
> Signed-off-by: Yash Omer<yashomer0007@...il.com>
> ---
>  drivers/staging/ks7010/ks_hostif.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> index 7bd567e233d7..36055652842d 100644
> --- a/drivers/staging/ks7010/ks_hostif.c
> +++ b/drivers/staging/ks7010/ks_hostif.c
> @@ -36,7 +36,7 @@ inline u8 get_BYTE(struct ks_wlan_private *priv)
>  {
>  	u8 data;
>  
> -	data = *(priv->rxp)++;
> +	data = *priv->rxp++;

Oh that's a mess, please just leave the original () there, otherwise you
have to really remember what order comes first here.  The () gives the
reader a huge hint as to what is being incremented.

thanks,

greg k-h