linux-kernel - Re: [PATCH v2] iio:pressure:ms5611: Fix coding style in probe function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180217124229.18d335fe@archlinux>
Date:   Sat, 17 Feb 2018 12:42:29 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     rodrigosiqueira <rodrigosiqueiramelo@...il.com>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        daniel.baluta@....com, linux-iio@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] iio:pressure:ms5611: Fix coding style in probe
 function

On Fri, 16 Feb 2018 17:44:41 -0200
rodrigosiqueira <rodrigosiqueiramelo@...il.com> wrote:

> This patch fixes the checkpatch.pl warning and error:
> 
> iio/pressure/ms5611.h:66: ERROR: code indent should use tabs where possible
> iio/pressure/ms5611.h:66: WARNING: please, no spaces at the start of a line
> iio/pressure/ms5611.h:66: ERROR: "foo* bar" should be "foo *bar"
> 
> Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@...il.com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks Daniel for your quick feedback on this.

Thanks,

Jonathan

> ---
> Changes in v2:
>   - Make the commit message more clearer.
> 
>  drivers/iio/pressure/ms5611.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/pressure/ms5611.h b/drivers/iio/pressure/ms5611.h
> index ccda63c5b3c3..ead9e9f85894 100644
> --- a/drivers/iio/pressure/ms5611.h
> +++ b/drivers/iio/pressure/ms5611.h
> @@ -63,7 +63,7 @@ struct ms5611_state {
>  };
>  
>  int ms5611_probe(struct iio_dev *indio_dev, struct device *dev,
> -                 const char* name, int type);
> +		 const char *name, int type);
>  int ms5611_remove(struct iio_dev *indio_dev);
>  
>  #endif /* _MS5611_H */