linux-kernel - Re: [PATCH] iio: chemical: ccs811: Typo correction in HW_ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180217141148.78246adc@archlinux>
Date:   Sat, 17 Feb 2018 14:12:16 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Richard Lai <richard@...hardman.com>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Narcisa Ana Maria Vasile <narcisaanamaria12@...il.com>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: chemical: ccs811: Typo correction in HW_ID_VALUE
 constant define naming

On Tue, 13 Feb 2018 22:36:57 +0000
Richard Lai <richard@...hardman.com> wrote:

> This particular constant was named with prefix "CCS881", which should be
> "CCS811" instead, just like the rest of constant names in the file, as this
> driver implementation is for AMS CCS811 sensor. "CCS881" could literally be
> referring to another sensor product unrelated to AMS CCS811 sensor.
> 
> Signed-off-by: Richard Lai <richard@...hardman.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/iio/chemical/ccs811.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/chemical/ccs811.c b/drivers/iio/chemical/ccs811.c
> index 840a6cb..8e8beb7 100644
> --- a/drivers/iio/chemical/ccs811.c
> +++ b/drivers/iio/chemical/ccs811.c
> @@ -31,7 +31,7 @@
>  #define CCS811_ALG_RESULT_DATA	0x02
>  #define CCS811_RAW_DATA		0x03
>  #define CCS811_HW_ID		0x20
> -#define CCS881_HW_ID_VALUE	0x81
> +#define CCS811_HW_ID_VALUE	0x81
>  #define CCS811_HW_VERSION	0x21
>  #define CCS811_HW_VERSION_VALUE	0x10
>  #define CCS811_HW_VERSION_MASK	0xF0
> @@ -315,7 +315,7 @@ static int ccs811_probe(struct i2c_client *client,
>  	if (ret < 0)
>  		return ret;
>  
> -	if (ret != CCS881_HW_ID_VALUE) {
> +	if (ret != CCS811_HW_ID_VALUE) {
>  		dev_err(&client->dev, "hardware id doesn't match CCS81x\n");
>  		return -ENODEV;
>  	}