linux-kernel - Re: [PATCH] USB: chaoskey: Use kasprintf() over strcpy()/strcat()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87k1vci0zf.fsf@keithp.com>
Date:   Fri, 16 Feb 2018 22:28:20 -0800
From:   "Keith Packard" <keithp@...thp.com>
To:     Kees Cook <keescook@...omium.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] USB: chaoskey: Use kasprintf() over strcpy()/strcat()

Kees Cook <keescook@...omium.org> writes:

> Instead of kmalloc() with manually calculated values followed by
> multiple strcpy()/strcat() calls, just fold it all into a single
> kasprintf() call.
>
> Signed-off-by: Kees Cook <keescook@...omium.org>

Reviewed-by: Keith Packard <keithp@...thp.com>

-- 
-keith

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)