linux-kernel - Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72m_jEyf9SBAOZEpCQ2gHptZVS4nQFhUxcOUdsuMWkC_Ww@mail.gmail.com>
Date:   Sun, 18 Feb 2018 20:56:49 +0100
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Philippe Ombredanne <pombredanne@...b.com>
Cc:     Willy Tarreau <w@....eu>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Linus Walleij <triad@...lth.se>, robin@...tonic.nl,
        Paul Burton <paul.burton@...s.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

On Sun, Feb 18, 2018 at 8:04 PM, Philippe Ombredanne
<pombredanne@...b.com> wrote:
> Miguel,
>
> On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda
> <miguel.ojeda.sandonis@...il.com> wrote:
>> Cc: Willy Tarreau <w@....eu>
>> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
>> Cc: Linus Walleij <triad@...lth.se>
>> Cc: Robin van der Gracht <robin@...tonic.nl>
>> Cc: Paul Burton <paul.burton@...s.com>
>> Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
>> ---
>
> <snip>
>
>> diff --git a/include/linux/cfag12864b.h b/include/linux/cfag12864b.h
>> index b454dfce60d9..aa960efc32f6 100644
>> --- a/include/linux/cfag12864b.h
>> +++ b/include/linux/cfag12864b.h
>> @@ -1,25 +1,11 @@
>> +// SPDX-License-Identifier: GPL-2.0
>
> Per the doc [1] you should be using instead this in a .h:
> /* SPDX-License-Identifier: GPL-2.0 */
>
> I know this can be surprising. This has been discussed on list quite
> lot and the doc has some rationale.

Thanks for taking the time to check the patch. It was a mistake on my
side -- I had actually read the docs but I recalled Linus talking
about moving to // at some point (and somehow my brain recorded that
the discussion was about the headers :-), so I thought I was actually
doing the right thing by using // already. Don't worry, I will fix it
when I put it in the queue.

Cheers,
Miguel

>
> <snip>
>
>> diff --git a/include/linux/ks0108.h b/include/linux/ks0108.h
>> index cb311798e0bc..2a1c985fedea 100644
>> --- a/include/linux/ks0108.h
>> +++ b/include/linux/ks0108.h
>> @@ -1,25 +1,11 @@
>> +// SPDX-License-Identifier: GPL-2.0
>
> Same comment as above.
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
>
> --
> Cordially
> Philippe Ombredanne