linux-kernel - Re: i2c-designware: sound and s2ram broken on Broadwell-U system since commit ca382f5b38f367b6 (add i2c gpio recovery option)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vf2sS8c4GubL1MRkrGdpYdn0n5stmzZNnp8axNn3AkEcw@mail.gmail.com>
Date:   Sun, 18 Feb 2018 16:23:41 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Dominik Brodowski <linux@...inikbrodowski.net>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        tim@...eglstein.org, Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Phil Reid <preid@...ctromag.com.au>,
        Wolfram Sang <wsa@...-dreams.de>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: i2c-designware: sound and s2ram broken on Broadwell-U system
 since commit ca382f5b38f367b6 (add i2c gpio recovery option)

On Sun, Feb 18, 2018 at 11:41 AM, Dominik Brodowski
<linux@...inikbrodowski.net> wrote:
> On Sat, Feb 17, 2018 at 10:57:01PM +0200, Andy Shevchenko wrote:
>> On Sat, 2018-02-17 at 17:58 +0100, Dominik Brodowski wrote:

>> >  Do you still need the DEBUG_GPIO output?
>>
>> It would be nice to have, though if it makes difficulties to you, then
>> don't bother.
>
> Note that I have to enable CONFIG_GPIOLIB before I can enable DEBUG_GPIO;
> CONFIG_PINCTRL was off as well. Maybe some "SELECT" is missing for
> CONFIG_I2C_DESIGNWARE_BAYTRAIL ?

Ah, so, your configuration misses pin control driver. You need to
enable it in order to get GPIOs working.
It might fix your issue w/o my patch.

> The following output is with your patch applied.

...which is useless.

> Do you need it without
> your fixup patch as well?

Yes, and with enabled pin control driver.

-- 
With Best Regards,
Andy Shevchenko