linux-kernel - Re: [PATCH v2 3/3] power: supply: axp288_fuel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ea75cd5f-9937-8b95-d96a-761fcd091594@redhat.com>
Date:   Mon, 19 Feb 2018 10:48:27 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Sebastian Reichel <sre@...nel.org>, Carlo Caione <carlo@...one.org>
Cc:     linux@...lessm.com, rjw@...ysocki.net, lenb@...nel.org,
        wens@...e.org, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        Carlo Caione <carlo@...lessm.com>
Subject: Re: [PATCH v2 3/3] power: supply: axp288_fuel_gauge: Do not register
 FG on ECS EF20EA

Hi,

On 16-02-18 15:26, Sebastian Reichel wrote:
> Hi,
> 
> On Fri, Feb 16, 2018 at 08:26:16AM +0000, Carlo Caione wrote:
>> From: Carlo Caione <carlo@...lessm.com>
>>
>> The ECS EF20EA laptop ships an AXP288 but it is actually using a
>> different, separate FG chip for AC and battery monitoring. On this
>> laptop we need to keep using the regular ACPI driver and disable the
>> AXP288 FG to avoid reporting two batteries to userspace.
>>
>> Signed-off-by: Carlo Caione <carlo@...lessm.com>
>> ---
> 
> It looks like this could be applied independently of the ACPI
> patches to the power-supply tree?

Yes this can be applied independently.

Regards,

Hans



> 
> -- Sebastian
> 
>>   drivers/power/supply/axp288_fuel_gauge.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c
>> index 4cc6e038dfdd..903891a9bcf0 100644
>> --- a/drivers/power/supply/axp288_fuel_gauge.c
>> +++ b/drivers/power/supply/axp288_fuel_gauge.c
>> @@ -708,6 +708,12 @@ static const struct dmi_system_id axp288_fuel_gauge_blacklist[] = {
>>   			DMI_MATCH(DMI_BOARD_VERSION, "V1.1"),
>>   		},
>>   	},
>> +	{
>> +		/* ECS EF20EA */
>> +		.matches = {
>> +			DMI_MATCH(DMI_PRODUCT_NAME, "EF20EA"),
>> +		},
>> +	},
>>   	{}
>>   };
>>   
>> -- 
>> 2.14.1
>>