linux-kernel - Re: [PATCH v3 5/7] watchdog: mtk: allow setting timeout in devicetree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46ff7605-5166-477b-85b1-7d2f53f7c57b@roeck-us.net>
Date:   Sun, 18 Feb 2018 17:08:32 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Rob Herring <robh@...nel.org>,
        Marcus Folkesson <marcus.folkesson@...il.com>
Cc:     Wim Van Sebroeck <wim@...ana.be>,
        Mark Rutland <mark.rutland@....com>,
        Carlo Caione <carlo@...one.org>,
        Kevin Hilman <khilman@...libre.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Barry Song <baohua@...nel.org>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Vladimir Zapolskiy <vz@...ia.com>,
        Sylvain Lemieux <slemieux.tyco@...il.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
        linux-watchdog@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v3 5/7] watchdog: mtk: allow setting timeout in devicetree

On 02/18/2018 04:08 PM, Rob Herring wrote:
> On Sun, Feb 11, 2018 at 09:08:45PM +0100, Marcus Folkesson wrote:
>> watchdog_init_timeout() will allways pick timeout_param since it
>> defaults to a valid timeout.
>>
>> By following best practice described in
>> Documentation/watchdog/watchdog-kernel-api.txt, it also
>> let us to set timout-sec property in devicetree.
> 
> Same problems in this one.
> 

Same answer. In the existing driver;

         mtk_wdt->wdt_dev.timeout = WDT_MAX_TIMEOUT;

Guenter

>>
>> Signed-off-by: Marcus Folkesson <marcus.folkesson@...il.com>
>> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
>> ---
>>   Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 4 ++++
>>   drivers/watchdog/mtk_wdt.c                             | 2 +-
>>   2 files changed, 5 insertions(+), 1 deletion(-)
>