linux-kernel - Re: [RESEND PATCH v5 2/5] dt-bindings: pwm-backlight: add PWM delay proprieties.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180219103936.vsvzbiwr3g7oqsyh@dell>
Date:   Mon, 19 Feb 2018 10:39:36 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Heiko Stuebner <heiko@...ech.de>
Cc:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Jingoo Han <jingoohan1@...il.com>,
        Rob Herring <robh+dt@...nel.org>, Pavel Machek <pavel@....cz>,
        Thierry Reding <thierry.reding@...il.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Richard Purdie <rpurdie@...ys.net>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        linux-pwm@...r.kernel.org, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, groeck@...omium.org,
        linux-rockchip@...ts.infradead.org, kernel@...labora.com
Subject: Re: [RESEND PATCH v5 2/5] dt-bindings: pwm-backlight: add PWM delay
 proprieties.

On Mon, 19 Feb 2018, Heiko Stuebner wrote:
> Am Montag, 19. Februar 2018, 10:22:47 CET schrieb Lee Jones:
> > On Fri, 16 Feb 2018, Enric Balletbo i Serra wrote:
> > 
> > > Hardware needs a delay between setting an initial (non-zero) PWM and
> > > enabling the backlight using GPIO. The post-pwm-on-delay-ms specifies
> > > this delay in milli seconds. Hardware also needs a delay between disabing
> > > the backlight using GPIO and setting PWM value to 0. The pwm-off-delay-ms
> > > is this delay in milli seconds.
> > > 
> > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> > > Acked-by: Pavel Machek <pavel@....cz>
> > > ---
> > > Based on the original Huang Lin <hl@...k-chips.com> work.
> > > 
> > > Changes since v4:
> > >  - Rebase on top of mainline.
> > > Changes since v3:
> > >  - Replace us for ms.
> > >  - Add Acked-by: Pavel Machek <pavel@....cz>
> > > Changes since v2:
> > >  - Use separate properties (Rob Herring)
> > > Changes since v1:
> > >  - As suggested by Daniel Thompson
> > >    - Do not assume power-on delay and power-off delay will be the same
> > > 
> > >  Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > 
> > Looks like this still needs an Ack.
> > 
> > Also, you didn't supply a 0th (cover-letter) patch, so I have no idea
> > of patch history or your future intentions.
> > 
> > Are there build-time dependencies between them or can each patch be
> > merged via their respective trees without the fear of merge/build
> > failure?
> 
> When looking at the patches, there do not seem to be any build-time
> dependencies between the patch 1-3 (backlight) and 4+5 devicetree,
> so after Rob hopefully has time to look at the binding change, I'd suspect
> you take the code changes and I'll take the dts changes.

Works for me.

-- 
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog