linux-kernel - Re: [PATCH 3/3] reset: simple: Allow user selection of driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1519040779.3408.7.camel@pengutronix.de>
Date:   Mon, 19 Feb 2018 12:46:19 +0100
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Joel Stanley <joel@....id.au>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Andrew Jeffery <andrew@...id.au>
Cc:     Lee Jones <lee.jones@...aro.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-aspeed@...ts.ozlabs.org
Subject: Re: [PATCH 3/3] reset: simple: Allow user selection of driver

On Mon, 2018-02-19 at 17:24 +1030, Joel Stanley wrote:
> Currently this driver is only user selectable if COMPILE_TEST is turned
> on. Users may wish to select (and deselect) it, so remove this
> restriction.

I would like to keep user visible options to a minimum unless there is a
good reason. What is the scenario in which a user would decide to
disable the default-enabled reset-simple driver, or the other way
around? This should be mentioned in the commit message.

Maybe this is an indication that there could be a better default than
just ARCH_ASPEED.

regards
Philipp

> Signed-off-by: Joel Stanley <joel@....id.au>
> ---
>  drivers/reset/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 18f152d251d7..7490a4370900 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -82,7 +82,7 @@ config RESET_PISTACHIO
>  	  This enables the reset driver for ImgTec Pistachio SoCs.
>  
>  config RESET_SIMPLE
> -	bool "Simple Reset Controller Driver" if COMPILE_TEST
> +	bool "Simple Reset Controller Driver"
>  	default ARCH_SOCFPGA || ARCH_STM32 || ARCH_STRATIX10 || ARCH_SUNXI || ARCH_ZX || ARCH_ASPEED
>  	help
>  	  This enables a simple reset controller driver for reset lines that