linux-kernel - Re: [PATCH 3/3] reset: simple: Allow user selection of driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACPK8Xe3bKSfp=PqL8Rm9ivaM5HN0M7FbJ9Bwf_O2D5MZxEpPQ@mail.gmail.com>
Date:   Mon, 19 Feb 2018 22:37:55 +1030
From:   Joel Stanley <joel@....id.au>
To:     Philipp Zabel <p.zabel@...gutronix.de>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Andrew Jeffery <andrew@...id.au>,
        Lee Jones <lee.jones@...aro.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-aspeed@...ts.ozlabs.org
Subject: Re: [PATCH 3/3] reset: simple: Allow user selection of driver

On Mon, Feb 19, 2018 at 10:16 PM, Philipp Zabel <p.zabel@...gutronix.de> wrote:
> On Mon, 2018-02-19 at 17:24 +1030, Joel Stanley wrote:
>> Currently this driver is only user selectable if COMPILE_TEST is turned
>> on. Users may wish to select (and deselect) it, so remove this
>> restriction.
>
> I would like to keep user visible options to a minimum unless there is a
> good reason. What is the scenario in which a user would decide to
> disable the default-enabled reset-simple driver, or the other way
> around? This should be mentioned in the commit message.

In this SoC's case the driver is not essential. A system that does not
use UART1..4 will not ever call on the driver. This situation is
common as the console uses UART5.

> Maybe this is an indication that there could be a better default than
> just ARCH_ASPEED.

This is an appropriate default, as it causes the least surprise to a
user. Without taking the UART out of reset, the kernel driver still
loads, but characters are never drained from the FIFO.

Advanced users may want to save the few kilobytes that an extra driver
adds, and the boot overhead of loading yet another driver. The saving
is small, so if you feel strongly about it we can drop this patch.

Cheers,

Joel

>
> regards
> Philipp
>
>> Signed-off-by: Joel Stanley <joel@....id.au>
>> ---
>>  drivers/reset/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
>> index 18f152d251d7..7490a4370900 100644
>> --- a/drivers/reset/Kconfig
>> +++ b/drivers/reset/Kconfig
>> @@ -82,7 +82,7 @@ config RESET_PISTACHIO
>>         This enables the reset driver for ImgTec Pistachio SoCs.
>>
>>  config RESET_SIMPLE
>> -     bool "Simple Reset Controller Driver" if COMPILE_TEST
>> +     bool "Simple Reset Controller Driver"
>>       default ARCH_SOCFPGA || ARCH_STM32 || ARCH_STRATIX10 || ARCH_SUNXI || ARCH_ZX || ARCH_ASPEED
>>       help
>>         This enables a simple reset controller driver for reset lines that