linux-kernel - Re: [PATCH v2 1/2] mfd: arizona: Update reset pin to use GPIOD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Feb 2018 15:36:29 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Charles Keepax <ckeepax@...nsource.cirrus.com>
Cc:     Lee Jones <lee.jones@...aro.org>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Linus Walleij <linus.walleij@...aro.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        patches@...nsource.cirrus.com
Subject: Re: [PATCH v2 1/2] mfd: arizona: Update reset pin to use GPIOD

On Mon, Feb 19, 2018 at 3:30 PM, Charles Keepax
<ckeepax@...nsource.cirrus.com> wrote:
> Now GPIOD has support for both pdata systems and for non-standard DT
> bindings the Arizona reset GPIO can be converted to use it.

>  static inline void arizona_enable_reset(struct arizona *arizona)
>  {
> -       if (arizona->pdata.reset)
> -               gpio_set_value_cansleep(arizona->pdata.reset, 0);
> +       gpiod_set_value_cansleep(arizona->pdata.reset, 0);
>  }

Did you try that code when !GPIOLIB ?

Or driver depends on it?

-- 
With Best Regards,
Andy Shevchenko