linux-kernel - Re: [PATCH v3 0/3] xen: re-enable booting as Xen PVH guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Feb 2018 15:43:40 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
Cc:     Juergen Gross <jgross@...e.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        xen-devel@...ts.xenproject.org,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        x86@...nel.org, Len Brown <lenb@...nel.org>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH v3 0/3] xen: re-enable booting as Xen PVH guest

On Mon, Feb 19, 2018 at 12:27 PM, Rafael J. Wysocki
<rafael.j.wysocki@...el.com> wrote:
> On 2/19/2018 11:09 AM, Juergen Gross wrote:
>>
>> The Xen PVH boot protocol passes vital information to the kernel via
>> a start_info block. One of the data transferred is the physical address
>> of the RSDP table.
>>
>> Unfortunately PVH support in the kernel didn't use that passed address
>> for RSDP, but relied on the legacy mechanism searching for the RSDP in
>> low memory. After a recent change in Xen putting the RSDP to a higher
>> address booting as PVH guest is now failing.
>>
>> This small series repairs that by passing the RSDP address from the
>> start_info block to ACPI handling.
>>
>> Changes in V3:
>> - instead of using a weak function add a function pointer to x86_init
>>    for obtaining the RSDP address
>>
>> Juergen Gross (3):
>>    acpi: introduce acpi_arch_get_root_pointer() for getting rsdp address
>>    x86/acpi: add a new x86_init_acpi structure to x86_init_ops
>>    x86/xen: add pvh specific rsdp address retrieval function
>>
>>   arch/x86/include/asm/acpi.h     |  7 +++++++
>>   arch/x86/include/asm/x86_init.h |  9 +++++++++
>>   arch/x86/kernel/x86_init.c      |  5 +++++
>>   arch/x86/xen/enlighten_pvh.c    | 14 +++++++++++---
>>   drivers/acpi/osl.c              |  5 ++++-
>>   include/linux/acpi.h            |  7 +++++++
>>   6 files changed, 43 insertions(+), 4 deletions(-)
>>
> The series is fine by me:
>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Don't know much about Xen, though the ACPI / x86 stubs are exactly
what I'm wanting!
Thanks.

Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

-- 
With Best Regards,
Andy Shevchenko