linux-kernel - Re: [PATCH 6/9] ASoC: Intel: sst: Free streams on suspend, re-alloc on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfjpRngR9_vE2SrHA_NRZdsap-2bEdRD6OEK63CTPBw2g@mail.gmail.com>
Date:   Mon, 19 Feb 2018 15:51:05 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6/9] ASoC: Intel: sst: Free streams on suspend, re-alloc
 on resume

On Mon, Feb 19, 2018 at 12:01 AM, Hans de Goede <hdegoede@...hat.com> wrote:
> The Bay Trail SST-DSP firmware version looses track of all streams over a
> suspend/resume, failing any attempts to resume and/or free streams, with
> a SST_ERR_INVALID_STREAM_ID error.
>
> This commit adds support for free-ing the streams on suspend and
> re-allocating them on resume, fixing suspend/resume issues on devices
> using this firmware version.
>
> This new behavior gets triggered by a new flag in sst_platform_info which
> only gets set on Bay Trail platforms.
>
> This has been tested on the following devices:
> -Asus T100TA,    Bay Trail    + ALC5642 codec
> -Ployer MOMO7W,  Bay Trail CR + ALC5652 codec


>  /* Cherryview (Cherrytrail and Braswell) uses same mrfld dpcm fw as Baytrail,
> - * so pdata is same as Baytrail.
> + * so pdata is same as Baytrail, minus the streams_lost_on_suspend quirk.
>   */

A nit, perhaps to fix multi line comment style as well?


-- 
With Best Regards,
Andy Shevchenko