linux-kernel - Re: [PATCH 1/9] ASoC: Intel: sst: Fix error-code check in sst_pause

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7f6b692-365d-a406-8d6d-f6422ac656f8@redhat.com>
Date:   Mon, 19 Feb 2018 15:00:06 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/9] ASoC: Intel: sst: Fix error-code check in
 sst_pause_stream()

Hi,

On 19-02-18 14:47, Andy Shevchenko wrote:
> On Mon, Feb 19, 2018 at 12:01 AM, Hans de Goede <hdegoede@...hat.com> wrote:
>> The value returned by sst_prepare_and_post_msg() is a negated SST_ERR_*
>> value, so we must check for -SST_ERR_INVALID_STREAM_ID. Note that
>> sst_pause_resume() already has the correct check.
>>
> 
> Should it have Fixes tag?

According to git blame this goes back to the original commit introducing
the file, so I don't think that that is helpful.

Regards,

Hans



> 
>> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
>> ---
>>   sound/soc/intel/atom/sst/sst_stream.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/intel/atom/sst/sst_stream.c b/sound/soc/intel/atom/sst/sst_stream.c
>> index 7ee6aeb7e0af..b082b0922a7a 100644
>> --- a/sound/soc/intel/atom/sst/sst_stream.c
>> +++ b/sound/soc/intel/atom/sst/sst_stream.c
>> @@ -253,7 +253,7 @@ int sst_pause_stream(struct intel_sst_drv *sst_drv_ctx, int str_id)
>>                  if (retval == 0) {
>>                          str_info->prev = str_info->status;
>>                          str_info->status = STREAM_PAUSED;
>> -               } else if (retval == SST_ERR_INVALID_STREAM_ID) {
>> +               } else if (retval == -SST_ERR_INVALID_STREAM_ID) {
>>                          retval = -EINVAL;
>>                          mutex_lock(&sst_drv_ctx->sst_lock);
>>                          sst_clean_stream(str_info);
>> --
>> 2.14.3
>>
> 
> 
>