linux-kernel - Re: [PATCH 1/2] dt-bindings: power: reset: gpio-poweroff: Add 'timeout' property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180219155939.uutemv6wnlxqa7oy@rob-hp-laptop>
Date:   Mon, 19 Feb 2018 09:59:39 -0600
From:   Rob Herring <robh@...nel.org>
To:     Moritz Fischer <moritz.fischer@...us.com>
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-pm@...r.kernel.org, mark.rutland@....com, sre@...nel.org,
        Moritz Fischer <mdf@...nel.org>
Subject: Re: [PATCH 1/2] dt-bindings: power: reset: gpio-poweroff: Add
 'timeout' property

On Thu, Feb 15, 2018 at 12:49:25PM -0800, Moritz Fischer wrote:
> From: Moritz Fischer <mdf@...nel.org>
> 
> Add 'timeout' property to support boards where the 3s timeout that the
> current driver defaults to is too short.
> 
> Signed-off-by: Moritz Fischer <mdf@...nel.org>
> ---
>  Documentation/devicetree/bindings/power/reset/gpio-poweroff.txt | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/power/reset/gpio-poweroff.txt b/Documentation/devicetree/bindings/power/reset/gpio-poweroff.txt
> index e62d53d844cc..c2459c7d45d5 100644
> --- a/Documentation/devicetree/bindings/power/reset/gpio-poweroff.txt
> +++ b/Documentation/devicetree/bindings/power/reset/gpio-poweroff.txt
> @@ -27,6 +27,8 @@ Optional properties:
>    it to an output when the power-off handler is called. If this optional
>    property is not specified, the GPIO is initialized as an output in its
>    inactive state.
> +- timeout: Time to wait before asserting a WARN_ON(1). If nothing is
> +           specified, 3000 ms is used.

Needs unit suffix as defined in property-units.txt.

>  
>  Examples:
>  
> @@ -34,3 +36,9 @@ gpio-poweroff {
>  	compatible = "gpio-poweroff";
>  	gpios = <&gpio 4 0>;
>  };
> +
> +gpio-poweroff {
> +	compatible = "gpio-poweroff";
> +	gpios = <&gpio 4 0>;
> +	timeout = <3000>;

Just add to the existing example.

> +};
> -- 
> 2.16.1
>