linux-kernel - Re: [PATCH] ptr_ring: Remove now-redundant smp_read_barrier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Feb 2018 11:11:38 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     parri.andrea@...il.com
Cc:     linux-kernel@...r.kernel.org, mst@...hat.com, jasowang@...hat.com,
        john.fastabend@...il.com, edumazet@...gle.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH] ptr_ring: Remove now-redundant
 smp_read_barrier_depends()

From: Andrea Parri <parri.andrea@...il.com>
Date: Fri, 16 Feb 2018 12:06:13 +0100

> Because READ_ONCE() now implies smp_read_barrier_depends(), the
> smp_read_barrier_depends() in __ptr_ring_consume() is redundant;
> this commit removes it and updates the comments.
> 
> Signed-off-by: Andrea Parri <parri.andrea@...il.com>

Ok, if READ_ONCE() does a barrier now, this change makes sense.

Applied to net-next, thank you.