linux-kernel - Re: [PATCH] x86: fix {pmd,pud}_{set,clear}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <44911e30-7d7a-14fd-1a70-ae3d92bfc771@suse.com>
Date:   Mon, 19 Feb 2018 17:23:02 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Jan Beulich <JBeulich@...e.com>, Ingo Molnar <mingo@...e.hu>,
        Thomas Gleixner <tglx@...utronix.de>,
        "H. Peter Anvin" <hpa@...or.com>
Cc:     Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: fix {pmd,pud}_{set,clear}_flags()

On 19/02/18 15:48, Jan Beulich wrote:
> Just like pte_{set,clear}_flags() their PMD and PUD counterparts should
> not do any address translation. This was outright wrong under Xen
> (causing a dead boot with no useful output on "suitable" systems), and
> produced needlessly more complicated code (even if just slightly) when
> paravirt was enabled.
> 
> Signed-off-by: Jan Beulich <jbeulich@...e.com>
> Cc: stable@...r.kernel.org 

While the changes look alright I'm really curious which kind of failure
you are seeing, especially considering how long those functions haven't
been changed (since more than 6 years).


Juergen