linux-kernel - Re: [PATCH] Staging: xgifb: fix lines should not end with open parenthesis in vb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Feb 2018 18:04:39 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Yash Omer <yashomer0007@...il.com>
Cc:     Larry.Finger@...inger.net, driverdev-devel@...uxdriverproject.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: xgifb: fix lines should not end with open
 parenthesis in vb_setmode.c

On Sat, Feb 17, 2018 at 12:12:36AM +0530, Yash Omer wrote:
> This patch fixes up line should not end with open parenthesis found by checkpatch.pl script.
> 
> Signed-off-by: Yash Omer <yashomer0007@...il.com>
> ---
>  drivers/staging/xgifb/vb_setmode.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> index 1fa0dc66406e..1d6ac724fd61 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -1228,8 +1228,8 @@ static void const *XGI_GetLcdPtr(struct XGI330_LCDDataTablStruct const *table,
>  	return table[i].DATAPTR;
>  }
>  
> -static struct SiS_TVData const *XGI_GetTVPtr(
> -	unsigned short ModeIdIndex,
> +static struct SiS_TVData const *XGI_GetTVPtr
> +(unsigned short ModeIdIndex,

Ick, that's horrid looking now, don't you think?

Please don't change things to make them look worse :)

greg k-h