linux-kernel - Re: [PATCH] sh: fix build error for empty CONFIG_BUILTIN_DTB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAS_yqOVKGOEJ_SrvigpqEKZoriuWGuCYdwEWtTtSMxetA@mail.gmail.com>
Date:   Tue, 20 Feb 2018 02:17:39 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>
Cc:     Nicholas Piggin <npiggin@...il.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        devicetree@...r.kernel.org,
        Linux-sh list <linux-sh@...r.kernel.org>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Rich Felker <dalias@...c.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH] sh: fix build error for empty CONFIG_BUILTIN_DTB_SOURCE

2018-02-20 2:09 GMT+09:00 Masahiro Yamada <yamada.masahiro@...ionext.com>:
> If CONFIG_USE_BUILTIN_DTB is enabled, but CONFIG_BUILTIN_DTB_SOURCE
> is empty (for example, allmodconfig), a build error occurs.
>
> Surround obj-y with ifneq ... endif.
>
> I replaced $(CONFIG_USE_BUILTIN_DTB) with 'y' since this is always
> the case from the following code from arch/sh/Makefile:
>
>   core-$(CONFIG_USE_BUILTIN_DTB)  += arch/sh/boot/dts/
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
>
>  arch/sh/boot/dts/Makefile | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/sh/boot/dts/Makefile b/arch/sh/boot/dts/Makefile
> index 715def0..01d0f7f 100644
> --- a/arch/sh/boot/dts/Makefile
> +++ b/arch/sh/boot/dts/Makefile
> @@ -1 +1,3 @@
> -obj-$(CONFIG_USE_BUILTIN_DTB) += $(patsubst "%",%,$(CONFIG_BUILTIN_DTB_SOURCE)).dtb.o
> +ifneq ($(CONFIG_BUILTIN_DTB_SOURCE),"")
> +obj-y += $(patsubst "%",%,$(CONFIG_BUILTIN_DTB_SOURCE)).dtb.o
> +endif



I inserted this before Nicholas' patch
to silence the test robot.


-- 
Best Regards
Masahiro Yamada