linux-kernel - Re: [PATCH 2/2] cpufreq: powernow-k8: Delete an unnecessary return statement in two functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180219034427.GK28462@vireshk-i7>
Date:   Mon, 19 Feb 2018 09:14:27 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     linux-pm@...r.kernel.org, "Rafael J. Wysocki" <rjw@...ysocki.net>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/2] cpufreq: powernow-k8: Delete an unnecessary return
 statement in two functions

On 15-02-18, 20:30, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 15 Feb 2018 20:14:32 +0100
> 
> The script "checkpatch.pl" pointed information out like the following.
> 
> WARNING: void function return statements are not generally useful
> 
> Thus remove such a statement in the affected functions.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/cpufreq/powernow-k8.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c
> index 460bf22a8a2b..782a8c2a359d 100644
> --- a/drivers/cpufreq/powernow-k8.c
> +++ b/drivers/cpufreq/powernow-k8.c
> @@ -122,14 +122,12 @@ static int query_current_values_with_pending_wait(struct powernow_k8_data *data)
>  static void count_off_irt(struct powernow_k8_data *data)
>  {
>  	udelay((1 << data->irt) * 10);
> -	return;
>  }
>  
>  /* the voltage stabilization time */
>  static void count_off_vst(struct powernow_k8_data *data)
>  {
>  	udelay(data->vstable * VST_UNITS_20US);
> -	return;
>  }
>  
>  /* need to init the control msr to a safe value (for each cpu) */

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh