linux-kernel - Re: [PATCH v2] xhci: Fix front USB ports on ASUS PRIME B350M-A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c32af5ea-c8ca-b68b-790e-102c7a8f89f6@linux.intel.com>
Date:   Tue, 20 Feb 2018 10:24:42 +0200
From:   Mathias Nyman <mathias.nyman@...ux.intel.com>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>,
        mathias.nyman@...el.com
Cc:     gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] xhci: Fix front USB ports on ASUS PRIME B350M-A

Hi

On 19.02.2018 21:06, Kai-Heng Feng wrote:
> When a USB device gets plugged on ASUS PRIME B350M-A's front ports, the
> xHC stops working:
> [  549.114587] xhci_hcd 0000:02:00.0: WARN: xHC CMD_RUN timeout
> [  549.114608] suspend_common(): xhci_pci_suspend+0x0/0xc0 returns -110
> [  549.114638] xhci_hcd 0000:02:00.0: can't suspend (hcd_pci_runtime_suspend returned -110)

Is the xhci runtime suspend something that you expected here?
I mean was the plugged device first enumerated normally, driver bound, inactive and runtime suspended
first?

> 
> Delay before running xHC command CMD_RUN can workaround the issue.
> 
> Use a new quirk to make the delay only targets to the affected xHC.

Is this some known issue with this chip, or something figured out by trial and error?

> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>

Thanks, otherwise workaround seems fine, just curious about the two details above

-Mathias