linux-kernel - [tip:x86/pti] x86/mm: Remove stale comment about KMEMCHECK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-3b3a9268bba62b35a29bafe0931715b1725fdf26@git.kernel.org>
Date:   Tue, 20 Feb 2018 02:26:06 -0800
From:   tip-bot for Jann Horn <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     mingo@...nel.org, jpoimboe@...hat.com, luto@...nel.org,
        peterz@...radead.org, hpa@...or.com, jannh@...gle.com,
        linux-kernel@...r.kernel.org, dvlasenk@...hat.com,
        tglx@...utronix.de, brgerst@...il.com,
        torvalds@...ux-foundation.org, bp@...en8.de
Subject: [tip:x86/pti] x86/mm: Remove stale comment about KMEMCHECK

Commit-ID:  3b3a9268bba62b35a29bafe0931715b1725fdf26
Gitweb:     https://git.kernel.org/tip/3b3a9268bba62b35a29bafe0931715b1725fdf26
Author:     Jann Horn <jannh@...gle.com>
AuthorDate: Mon, 19 Feb 2018 18:50:39 +0100
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Tue, 20 Feb 2018 09:33:39 +0100

x86/mm: Remove stale comment about KMEMCHECK

This comment referred to a conditional call to kmemcheck_hide() that was
here until commit 4950276672fc ("kmemcheck: remove annotations").

Now that kmemcheck has been removed, it doesn't make sense anymore.

Signed-off-by: Jann Horn <jannh@...gle.com>
Acked-by: Thomas Gleixner <tglx@...utronix.de>
Cc: Andy Lutomirski <luto@...nel.org>
Cc: Borislav Petkov <bp@...en8.de>
Cc: Brian Gerst <brgerst@...il.com>
Cc: Denys Vlasenko <dvlasenk@...hat.com>
Cc: H. Peter Anvin <hpa@...or.com>
Cc: Josh Poimboeuf <jpoimboe@...hat.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Link: http://lkml.kernel.org/r/20180219175039.253089-1-jannh@google.com
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 arch/x86/mm/fault.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
index 800de81..c88573d 100644
--- a/arch/x86/mm/fault.c
+++ b/arch/x86/mm/fault.c
@@ -1248,10 +1248,6 @@ __do_page_fault(struct pt_regs *regs, unsigned long error_code,
 	tsk = current;
 	mm = tsk->mm;
 
-	/*
-	 * Detect and handle instructions that would cause a page fault for
-	 * both a tracked kernel page and a userspace page.
-	 */
 	prefetchw(&mm->mmap_sem);
 
 	if (unlikely(kmmio_fault(regs, address)))