linux-kernel - RE: [lustre-devel] [PATCH 14/21] staging: lustre: fix assorted checkpatch errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Feb 2018 10:50:25 +0000
From:   "Eremin, Dmitry" <dmitry.eremin@...el.com>
To:     NeilBrown <neilb@...e.com>, "Drokin, Oleg" <oleg.drokin@...el.com>,
        "James Simmons" <jsimmons@...radead.org>,
        "Dilger, Andreas" <andreas.dilger@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     lkml <linux-kernel@...r.kernel.org>,
        lustre <lustre-devel@...ts.lustre.org>
Subject: RE: [lustre-devel] [PATCH 14/21] staging: lustre: fix assorted
 checkpatch errors

> -----Original Message-----
> Thanks for the review.  Yes, you are correct.
> I had seen that end_dirent was initialized to NULL, and let myself
> believe that would make the transformation safe.
> In fact, that initialization to NULL is pointless as it is never used.
> 
> Maybe this would be better
> 
> @@ -1055,13 +1055,14 @@ static void mdc_adjust_dirpages(struct page
> **pages, int cfs_pgs, int lu_pgs)
>  		__u64 hash_end = le64_to_cpu(dp->ldp_hash_end);
>  		__u32 flags = le32_to_cpu(dp->ldp_flags);
>  		struct lu_dirpage *first = dp;
> -		struct lu_dirent *end_dirent = NULL;
> -		struct lu_dirent *ent;
> 
>  		while (--lu_pgs > 0) {
> -			ent = lu_dirent_start(dp);
> -			for (end_dirent = ent; ent;
> -			     end_dirent = ent, ent = lu_dirent_next(ent));
> +			struct lu_dirent *end_dirent = NULL;
> +			struct lu_dirent *ent;
> +
> +			for (ent = lu_dirent_start(dp); ent;
> +			     ent = lu_dirent_next(ent))
> +				end_dirent = ent;
> 
>  			/* Advance dp to next lu_dirpage. */
>  			dp = (struct lu_dirpage *)((char *)dp + LU_PAGE_SIZE);
> ??

Thanks, I agree with this version.

Dmitry.

--------------------------------------------------------------------
Joint Stock Company Intel A/O
Registered legal address: Krylatsky Hills Business Park,
17 Krylatskaya Str., Bldg 4, Moscow 121614,
Russian Federation

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.