linux-kernel - Re: [PATCH 2/2] ASoC: max9759: Add Amplifier Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180220120521.GC6378@sirena.org.uk>
Date:   Tue, 20 Feb 2018 12:05:21 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Neil Armstrong <narmstrong@...libre.com>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ASoC: max9759: Add Amplifier Driver

On Mon, Feb 19, 2018 at 02:45:58PM +0100, Neil Armstrong wrote:

> +++ b/sound/soc/codecs/max9759.c
> @@ -0,0 +1,207 @@
> +// SPDX-Licence-Identifier: GPL-2.0
> +/*
> + * MAX9759 Amplifier Driver
> + *

Please don't mix C and C++ style comments like this, make it all a C++
comment - it looks more intentional.  Otherwise this looks good so I'll
apply, please send an incremental fixup.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)