linux-kernel - Re: [PATCH v2 2/2] power: reset: gpio-poweroff: Add support for timeout from DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180220164122.GA32079@tyrael.ni.corp.natinst.com>
Date:   Tue, 20 Feb 2018 08:41:22 -0800
From:   Moritz Fischer <mdf@...nel.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Moritz Fischer <mdf@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        Sebastian Reichel <sre@...nel.org>
Subject: Re: [PATCH v2 2/2] power: reset: gpio-poweroff: Add support for
 timeout from DT

On Tue, Feb 20, 2018 at 04:12:59PM +0200, Andy Shevchenko wrote:
> On Tue, Feb 20, 2018 at 12:59 AM, Moritz Fischer <mdf@...nel.org> wrote:
> > Add support for reading a timeout value from devicetree.
> > Fall back to previous default of 3s if nothing is specified.
> 
> 
> > +       of_property_read_u32(pdev->dev.of_node, "timeout_ms", &timeout);
> 
> Perhaps stop being OF-centric by using device_property_read_u32() instead?

Good catch, will do. Should probably change commit message accordingly,
too.

Thanks,

Moritz

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)