linux-kernel - Re: [PATCH] max17042: propagate of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vck_8G=zTD4ftYC7yd+q_6XiXWvs+kX_zqr6bUtMUf4wg@mail.gmail.com>
Date:   Tue, 20 Feb 2018 19:34:37 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Pierre Bourdon <delroth@...gle.com>
Cc:     Andre Heider <a.heider@...il.com>,
        Sebastian Reichel <sre@...nel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] max17042: propagate of_node to power supply device

On Tue, Feb 20, 2018 at 5:03 PM, Pierre Bourdon <delroth@...gle.com> wrote:
> max17042_get_status uses the core power_supply_am_i_supplied. That
> function relies on DT properties to figure out the power supply
> topology, and will error out without DT.

> +       psy_cfg.of_node = dev->of_node;

Perhaps do this in general manner, see how GPIOLIB takes care of it:

$ git grep -n -A4 -w CONFIG_OF_GPIO -- drivers/gpio/gpiolib.c
drivers/gpio/gpiolib.c:1161:#ifdef CONFIG_OF_GPIO
drivers/gpio/gpiolib.c-1162-    /* If the gpiochip has an assigned OF
node this takes precedence */
drivers/gpio/gpiolib.c-1163-    if (chip->of_node)
drivers/gpio/gpiolib.c-1164-            gdev->dev.of_node = chip->of_node;
drivers/gpio/gpiolib.c-1165-#endif
...

-- 
With Best Regards,
Andy Shevchenko