linux-kernel - Re: [PATCH v9 03/11] media: platform: Add Renesas CEU driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201802201109.ccyy6G7i%fengguang.wu@intel.com>
Date:   Tue, 20 Feb 2018 11:35:06 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Jacopo Mondi <jacopo+renesas@...ndi.org>
Cc:     kbuild-all@...org, laurent.pinchart@...asonboard.com,
        magnus.damm@...il.com, geert@...der.be, hverkuil@...all.nl,
        mchehab@...nel.org, festevam@...il.com, sakari.ailus@....fi,
        robh+dt@...nel.org, mark.rutland@....com, pombredanne@...b.com,
        Jacopo Mondi <jacopo+renesas@...ndi.org>,
        linux-renesas-soc@...r.kernel.org, linux-media@...r.kernel.org,
        linux-sh@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 03/11] media: platform: Add Renesas CEU driver

Hi Jacopo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.16-rc2 next-20180220]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jacopo-Mondi/Renesas-Capture-Engine-Unit-CEU-V4L2-driver/20180220-101027
base:   git://linuxtv.org/media_tree.git master
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/media/platform/renesas-ceu.c: In function 'ceu_g_parm':
>> drivers/media/platform/renesas-ceu.c:1177:9: error: implicit declaration of function 'v4l2_g_parm_cap'; did you mean 'v4l2_g_ctrl'? [-Werror=implicit-function-declaration]
     return v4l2_g_parm_cap(video_devdata(file), ceudev->sd->v4l2_sd, a);
            ^~~~~~~~~~~~~~~
            v4l2_g_ctrl
   drivers/media/platform/renesas-ceu.c: In function 'ceu_s_parm':
>> drivers/media/platform/renesas-ceu.c:1184:9: error: implicit declaration of function 'v4l2_s_parm_cap'; did you mean 'v4l2_s_ctrl'? [-Werror=implicit-function-declaration]
     return v4l2_s_parm_cap(video_devdata(file), ceudev->sd->v4l2_sd, a);
            ^~~~~~~~~~~~~~~
            v4l2_s_ctrl
   drivers/media/platform/renesas-ceu.c: In function 'ceu_start_streaming':
   drivers/media/platform/renesas-ceu.c:290:2: warning: 'cdwdr' may be used uninitialized in this function [-Wmaybe-uninitialized]
     iowrite32(data, priv->base + reg_offs);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/media/platform/renesas-ceu.c:338:27: note: 'cdwdr' was declared here
     u32 camcr, cdocr, cfzsr, cdwdr, capwr;
                              ^~~~~
   drivers/media/platform/renesas-ceu.c:290:2: warning: 'cfzsr' may be used uninitialized in this function [-Wmaybe-uninitialized]
     iowrite32(data, priv->base + reg_offs);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/media/platform/renesas-ceu.c:338:20: note: 'cfzsr' was declared here
     u32 camcr, cdocr, cfzsr, cdwdr, capwr;
                       ^~~~~
   drivers/media/platform/renesas-ceu.c:418:8: warning: 'camcr' may be used uninitialized in this function [-Wmaybe-uninitialized]
     camcr |= mbus_flags & V4L2_MBUS_HSYNC_ACTIVE_LOW ? 1 << 0 : 0;
     ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/media/platform/renesas-ceu.c:338:6: note: 'camcr' was declared here
     u32 camcr, cdocr, cfzsr, cdwdr, capwr;
         ^~~~~
   drivers/media/platform/renesas-ceu.c: In function 'ceu_probe':
   drivers/media/platform/renesas-ceu.c:1623:9: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
     return ret;
            ^~~
   cc1: some warnings being treated as errors

vim +1177 drivers/media/platform/renesas-ceu.c

  1172	
  1173	static int ceu_g_parm(struct file *file, void *fh, struct v4l2_streamparm *a)
  1174	{
  1175		struct ceu_device *ceudev = video_drvdata(file);
  1176	
> 1177		return v4l2_g_parm_cap(video_devdata(file), ceudev->sd->v4l2_sd, a);
  1178	}
  1179	
  1180	static int ceu_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a)
  1181	{
  1182		struct ceu_device *ceudev = video_drvdata(file);
  1183	
> 1184		return v4l2_s_parm_cap(video_devdata(file), ceudev->sd->v4l2_sd, a);
  1185	}
  1186	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (63085 bytes)