linux-kernel - Re: [PATCHv2 1/8] MIPS: Loongson64: cleanup all cs5536 files to use SPDX Identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 20 Feb 2018 23:06:16 +0000
From:   James Hogan <jhogan@...nel.org>
To:     Jiaxun Yang <jiaxun.yang@...goat.com>
Cc:     Ralf Baechle <ralf@...ux-mips.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Linux MIPS <linux-mips@...ux-mips.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv2 1/8] MIPS: Loongson64: cleanup all cs5536 files to use
 SPDX Identifier

On Sun, Dec 31, 2017 at 02:28:24AM +0800, Jiaxun Yang wrote:
> diff --git a/arch/mips/loongson64/common/cs5536/cs5536_acc.c b/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> index ab4d6cc57384..ba0474bb4a3d 100644
> --- a/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> +++ b/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> @@ -1,3 +1,5 @@
> +// SPDX-License-Identifier: GPL-2.0
> +

No other cases I've seen bother with the blank line. Please remove
throughout the series.

>  /*
>   * the ACC Virtual Support Module of AMD CS5536
>   *
> @@ -7,10 +9,6 @@
>   * Copyright (C) 2009 Lemote, Inc.
>   * Author: Wu Zhangjin, wuzhangjin@...il.com
>   *
> - * This program is free software; you can redistribute	it and/or modify it
> - * under  the terms of	the GNU General	 Public License as published by the
> - * Free Software Foundation;  either version 2 of the  License, or (at your
> - * option) any later version.

or any later version implies it should be "GPL-2.0+"

Same throughout. Please check carefully you aren't changing the stated
license on any files.

Cheers
James

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)