linux-kernel - Re: [PATCH v3 0/6] Topstar U931/RVP7 ACPI LED Workaround

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VddGSmyOcHdzPFg=F2uHTvD6fqtGNuMnhsp1a57nmozoA@mail.gmail.com>
Date:   Wed, 21 Feb 2018 17:27:33 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Guillaume Douézan-Grard 
        <gdouezangrard@...il.com>
Cc:     Andy Shevchenko <andy@...radead.org>,
        Darren Hart <dvhart@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 0/6] Topstar U931/RVP7 ACPI LED Workaround

On Wed, Feb 21, 2018 at 5:12 PM, Guillaume Douézan-Grard
<gdouezangrard@...il.com> wrote:
> Hi Andy,
>
> Thank you for your review. Changes since the previous submission are
> highlighted below.
>
> On Topstar U931/RVP7 Notebooks, an issue prevents the WLAN toggle key
> from being properly managed by the Embedded Controller and successfully
> disconnect the adapter. A specific ACPI method allows to toggle the WLAN
> LED state regardless.
>
> Based on a DMI check, the LED is registered within the corresponding
> subsystem, making possible to use a software-based trigger (rfkill for
> instance, to synchronize the LED with the network interface state).
>
> Thank you for your time,

Couple of style things. otherwise looks good to me.

>
> --
> Guillaume Douézan-Grard
>
>
> Changes since v2:
>
> * revert an older conversion from a generic module to an acpi driver
> module instead of undoing it manually,
> * separate commits for the renaming and the spliting phases,
> * DMI-based check instead of a module parameter,
> * copyright and minor fixes put at the end.
>
>
> Changes since v1:
>
> * leave devices names unchanged for ABI compatibility,
> * fix label names,
> * separate module authors definition,
> * add commit description to Patch 3.
>
>
> Guillaume Douézan-Grard (6):
>   revert "topstar-laptop: convert to module_acpi_driver()"
>   platform/x86: topstar-laptop: use consistent naming scheme
>   platform/x86: topstar-laptop: split ACPI events and input handling
>   platform/x86: topstar-laptop: add platform device
>   platform/x86: topstar-laptop: add Topstar U931/RVP7 WLAN LED
>     workaround
>   platform/x86: topstar-laptop: update copyright and fix some comments
>
>  drivers/platform/x86/Kconfig          |   2 +
>  drivers/platform/x86/topstar-laptop.c | 358 +++++++++++++++++++++++++++-------
>  2 files changed, 290 insertions(+), 70 deletions(-)
>
> --
> 2.16.1
>



-- 
With Best Regards,
Andy Shevchenko