linux-kernel - Re: [PATCH] iio:dummy: Fix coding style in simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZAhZ=PR+X3=HYRQKkTHUnczWcsv4945piCrwK31PbuXGg@mail.gmail.com>
Date:   Wed, 21 Feb 2018 18:04:24 +0200
From:   Daniel Baluta <daniel.baluta@...il.com>
To:     Rodrigo Siqueira <rodrigosiqueiramelo@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Daniel Baluta <daniel.baluta@....com>,
        linux-iio@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio:dummy: Fix coding style in simple_dummy and evgen

On Wed, Feb 21, 2018 at 4:05 PM, Rodrigo Siqueira
<rodrigosiqueiramelo@...il.com> wrote:
> This patch fixes the following checkpatch.pl warnings:
>
> drivers/iio/dummy/iio_simple_dummy.c:603: WARNING: Block comments should
> align the * on each line
> drivers/iio/dummy/iio_dummy_evgen.c:151: WARNING: Symbolic permissions
> 'S_IWUSR' are not preferred. Consider using octal permissions '0200'...
> drivers/iio/dummy/iio_simple_dummy.c:693: CHECK: Please use a blank line
> after function/struct/union/enum declarations

You are trying to fix 3 things in one patch here. Please don't do that.

One patch per change please.

thanks,
Daniel.