linux-kernel - Re: [PATCH v4 5/7] platform/x86: topstar-laptop: add Topstar U931/RVP7 WLAN LED workaround

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180221163949.GA21098@localhost>
Date:   Wed, 21 Feb 2018 17:39:49 +0100
From:   Guillaume Douézan-Grard <gdouezangrard@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Andy Shevchenko <andy@...radead.org>,
        Darren Hart <dvhart@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 5/7] platform/x86: topstar-laptop: add Topstar
 U931/RVP7 WLAN LED workaround

On Wed, Feb 21, 2018 at 06:25:10PM +0200, Andy Shevchenko wrote:
> On Wed, Feb 21, 2018 at 6:10 PM, Guillaume Douézan-Grard
> <gdouezangrard@...il.com> wrote:
> > Topstar U931 laptops provide a LED synced with the WLAN adapter
> > hard-blocking state. Unfortunately, some models seem to be defective,
> > making impossible to hard-block the adapter with the WLAN switch and
> > thus the LED is useless.
> >
> > An ACPI method is available to programmatically control this switch and
> > it indirectly allows to control the LED.
> >
> > This commit registers the LED within the corresponding subsystem, making
> > possible for instance to use an rfkill-based trigger to synchronize the
> > LED with the device state.
> >
> > This workaround is enabled automatically for Topstar U931/RVP7 laptops
> > based on a DMI check.
> 
> > - * ACPI driver for Topstar notebooks (hotkeys support only)
> > + * Topstar Laptop ACPI Extras driver
> 
> Nope.
> I think it's previous one.

Previous one is still technically "hotkeys support only", but I'll
change this.

(and sorry for the license mismatch, I fix that right now...)

--
Guillaume Douézan-Grard