linux-kernel - Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180221182340.wvdvgtv5pw7pvd3v@verge.net.au>
Date:   Wed, 21 Feb 2018 19:23:40 +0100
From:   Simon Horman <horms@...ge.net.au>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:     jacopo mondi <jacopo@...ndi.org>,
        Jacopo Mondi <jacopo+renesas@...ndi.org>, geert@...ux-m68k.org,
        magnus.damm@...il.com, robh+dt@...nel.org, mark.rutland@....com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

On Wed, Feb 21, 2018 at 08:53:53PM +0300, Sergei Shtylyov wrote:
> On 02/21/2018 08:38 PM, Sergei Shtylyov wrote:

...

> >>>>>> +			clocks = <&cpg CPG_MOD 812>;
> >>>>>> +			power-domains = <&sysc 32>;
> >>>>>> +			resets = <&cpg 812>;
> >>>>>> +			phy-mode = "rgmii-txid";
> >>>>>
> >>>>>    Why not just "rgmii"? TX delay is a board specific detail, no?
> >>>>>
> >>>> I admit I took this one straight from r8a7796 dtsi.
> >>>> Would you like to me resend and change this?
> >>>
> >>>    Yes, unless Simon would fix it while merging...
> >>
> >> Can I confirm the desired change is s/rgmii-txid/rgmii/ ?
> > 
> >    Yes.
> 
>    Apparently that means that this prop should be overridden in the board file
> (which may not be an easy task given the board is Salvator-XS again).
> 
> [...]

Can we override it in r8a77965-salvator-x.dts or r8a77965-salvator-xs.dts?

I feel that I'm missing an important point here.