linux-kernel - Re: [PATCH 1/5] proc: make /proc/*/cmdline go through LSM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180221120627.9e134187df86df7c08ad78ca@linux-foundation.org>
Date:   Wed, 21 Feb 2018 12:06:27 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] proc: make /proc/*/cmdline go through LSM

On Wed, 21 Feb 2018 22:23:39 +0300 Alexey Dobriyan <adobriyan@...il.com> wrote:

> /proc/*/cmdline is not different from /proc/*/environ as it accesses
> target task's memory (and can access the very same region of memory)
> but it doesn't go through ptrace_may_access() and thus doesn't go through LSM.
> 

I'd really like to see more thoughtful changelogging, please.

Why are we doing this?  What is the advantage?

Doesn't this mean that code which could previously read
/proc/pid/cmdline may no longer be able to do so?  Can't this break
userspace?  Discuss.  Lots!