linux-kernel - Re: [RESEND PATCH v2 2/2] ASoC: topology: Add missing clock gating parameter when parsing hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c30eb9d9-11ff-f5c9-bb4e-ab0f9a8f4c09@gmail.com>
Date:   Wed, 21 Feb 2018 21:16:15 +0100
From:   Kirill Marinushkin <k.marinushkin@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Mark Brown <broonie@...nel.org>,
        Takashi Sakamoto <o-takashi@...amocchi.jp>,
        Takashi Iwai <tiwai@...e.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Liam Girdwood <lgirdwood@...il.com>,
        ALSA Development Mailing List <alsa-devel@...a-project.org>
Subject: Re: [RESEND PATCH v2 2/2] ASoC: topology: Add missing clock gating
 parameter when parsing hw_configs

On 02/21/18 15:50, Andy Shevchenko wrote:
> On Tue, Feb 20, 2018 at 7:44 PM, Kirill Marinushkin
> <k.marinushkin@...il.com> wrote:
>> Clock gating parameter is a part of `dai_fmt`. It is supported by
>> `alsa-lib` when creating a topology binary file, but ignored by kernel
>> when loading this topology file.
>> +               /* clock gating */
>> +               if (hw_config->clock_gated == SND_SOC_TPLG_DAI_CLK_GATE_GATED)
>> +                       link->dai_fmt |= SND_SOC_DAIFMT_GATED;
>> +               else if (hw_config->clock_gated ==
>> +                        SND_SOC_TPLG_DAI_CLK_GATE_CONT)
> A nit, I would leave it on the same line, even if it ~2-3 characters
> longer than 80.

Hello Andy,

Thank you for the comment.

I think it is important to stay in the length of 80. I understand your point, but from my perspective, the coding style is a higher priority guideline.

Therefore I would prefer to keep this line as it is now.

Beast Regards,
Kirill

>> +                       link->dai_fmt |= SND_SOC_DAIFMT_CONT;
>> +