linux-kernel - Re: [PATCH v2] proc: fix /proc/*/map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180221202911.GC2092@uranus.lan>
Date:   Wed, 21 Feb 2018 23:29:11 +0300
From:   Cyrill Gorcunov <gorcunov@...il.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Alexey Dobriyan <adobriyan@...il.com>,
        linux-kernel@...r.kernel.org, avagin@...tuozzo.com,
        viro@...iv.linux.org.uk
Subject: Re: [PATCH v2] proc: fix /proc/*/map_files lookup some more

On Wed, Feb 21, 2018 at 12:04:03PM -0800, Andrew Morton wrote:
> 
> I don't know this code and I'm all confused.
> 
> - why is the code designed to accept addresses of "0"?

It was never designed to accept addresses of 0, it is rather
a side effect of using sscanf in first place.

The address priting is done via

	len = snprintf(buf, sizeof(buf), "%lx-%lx", p->start, p->end);

> - how do we know that the first digit of a VMA address will never be 0?

It should not be, due to snprintf above.
---

Thanks a lot, Alexey!

Reviewed-by: Cyrill Gorcunov <gorcunov@...nvz.org>