linux-kernel - Re: [PATCH] tools/gpio/gpio-event-mon: fix warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEUSe7-4pyGvDXKECtc_aoikmNERWGvLecuCYXBCAxLO44gwmw@mail.gmail.com>
Date:   Wed, 21 Feb 2018 15:41:49 -0600
From:   Daniel Díaz Rodríguez 
        <daniel.diaz@...aro.org>
To:     Anders Roxell <anders.roxell@...aro.org>
Cc:     linus.walleij@...aro.org, linux-gpio@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tools/gpio/gpio-event-mon: fix warning

On 21 February 2018 at 15:33, Anders Roxell <anders.roxell@...aro.org> wrote:
> PRIu64 is defined in user space to match libc's uint64_t definition.
> However, gpioevent_data structure in the kernel is defined using the
> kernel's own __u64 type.
>
> gpio-event-mon.c: In function ‘monitor_device’:
> gpio-event-mon.c:102:19: warning: format ‘%lu’ expects argument of type
>     ‘long unsigned int’, but argument 3 has type ‘__u64 {aka long long
>     unsigned int}’ [-Wformat=]
>    fprintf(stdout, "GPIO EVENT %" PRIu64 ": ", event.timestamp);
>                    ^~~~~~~~~~~~~~
>   LD       /tmp/kselftest/gpiogpio-event-mon-in.o
>   LINK     /tmp/kselftest/gpiogpio-event-mon
>
> Fix is to replace PRIu64 with llu, which we know is what the kernel uses
> for __u64.
>
> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>

Tested-by: Daniel Díaz <daniel.diaz@...aro.org>


> ---
>  tools/gpio/gpio-event-mon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/gpio/gpio-event-mon.c b/tools/gpio/gpio-event-mon.c
> index dac4d4131d9b..c864544efe05 100644
> --- a/tools/gpio/gpio-event-mon.c
> +++ b/tools/gpio/gpio-event-mon.c
> @@ -99,7 +99,7 @@ int monitor_device(const char *device_name,
>                         ret = -EIO;
>                         break;
>                 }
> -               fprintf(stdout, "GPIO EVENT %" PRIu64 ": ", event.timestamp);
> +               fprintf(stdout, "GPIO EVENT %llu: ", event.timestamp);
>                 switch (event.id) {
>                 case GPIOEVENT_EVENT_RISING_EDGE:
>                         fprintf(stdout, "rising edge");
> --
> 2.11.0