linux-kernel - Re: [PATCH] mmc: dw_mmc-k3: Fix out-of-bounds access through DT alias

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdU9fbATp04Cvq8vJ_3-gEw8br3YA-AGGFh2L0caJ-0Jhw@mail.gmail.com>
Date:   Wed, 21 Feb 2018 10:34:58 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Jaehoon Chung <jh80.chung@...sung.com>
Cc:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Linux MMC List <linux-mmc@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: dw_mmc-k3: Fix out-of-bounds access through DT alias

Hi Jaehoon,

On Wed, Feb 21, 2018 at 6:39 AM, Jaehoon Chung <jh80.chung@...sung.com> wrote:
> On 02/20/2018 07:50 PM, Geert Uytterhoeven wrote:
>> On Tue, Feb 20, 2018 at 10:03 AM, Geert Uytterhoeven
>> <geert+renesas@...der.be> wrote:
>>> The hs_timing_cfg[] array is indexed using a value derived from the
>>> "mshcN" alias in DT, which may lead to an out-of-bounds access.
>>>
>>> Fix this by adding a range check.
>>>
>>> Fixes: 7d92895208a008a2 ("mmc: dw_mmc-k3: Fix out-of-bounds access through DT alias")
>>
>> Oops
>>
>> Fixes: 361c7fe9b02eee7e ("mmc: dw_mmc-k3: add sd support for hi3660")
>
> Could you resend the patch with changing commit-msg?
> Then i will pick yours.

Sure. Will send a v2 soon.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds