linux-kernel - Re: [PATCH] mm/page_poison: Make early_page_poison_param _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 21 Feb 2018 11:16:26 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Dou Liyang <douly.fnst@...fujitsu.com>
Cc:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-mm@...ck.org
Subject: Re: [PATCH] mm/page_poison: Make early_page_poison_param __init

On Wed 17-01-18 11:47:57, Dou Liyang wrote:
> The early_param() is only called during kernel initialization, So Linux
> marks the function of it with __init macro to save memory.
> 
> But it forgot to mark the early_page_poison_param(). So, Make it __init
> as well.
> 
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Philippe Ombredanne <pombredanne@...b.com>
> Cc: Kate Stewart <kstewart@...uxfoundation.org>
> Cc: Michal Hocko <mhocko@...e.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: linux-mm@...ck.org
> Signed-off-by: Dou Liyang <douly.fnst@...fujitsu.com>

Acked-by: Michal Hocko <mhocko@...e.com>

> ---
>  mm/page_poison.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/page_poison.c b/mm/page_poison.c
> index e83fd44867de..aa2b3d34e8ea 100644
> --- a/mm/page_poison.c
> +++ b/mm/page_poison.c
> @@ -9,7 +9,7 @@
>  
>  static bool want_page_poisoning __read_mostly;
>  
> -static int early_page_poison_param(char *buf)
> +static int __init early_page_poison_param(char *buf)
>  {
>  	if (!buf)
>  		return -EINVAL;
> -- 
> 2.14.3
> 
> 
> 

-- 
Michal Hocko
SUSE Labs