linux-kernel - Re: [PATCH 2/2] proc: use set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180220160212.8f3942d40e0b4014e2aa457c@linux-foundation.org>
Date:   Tue, 20 Feb 2018 16:02:12 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Alexey Dobriyan <adobriyan@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] proc: use set_puts() at /proc/*/wchan

On Sat, 17 Feb 2018 16:06:42 +0200 Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Sat, Feb 17, 2018 at 9:20 AM, Alexey Dobriyan <adobriyan@...il.com> wrote:
> > Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
> 
> 
> > -               seq_printf(m, "%s", symname);
> > +               seq_puts(m, symname);
> 
> While this might have no security concerns, the pattern might be
> brainlessly used by some janitors and there would have security
> implications.

And I'd like to see a changelog, please.  One which explains why
`symname' cannot have a %s (etc) in it, and never will.